feat(synthetics): Update Cloudwatch Synthetics canaries NodeJS runtimes by flochaz · Pull Request #11866 · aws/aws-cdk

flochaz · 2020-12-04T08:09:50Z

Cloudwatch Synthetics recently released new NodeJS runtimes (https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Synthetics_Library_nodejs_puppeteer.html).

This PR is adding them and update doc links

Fixes #11870

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

gitpod-io · 2020-12-04T08:09:58Z

mergify · 2020-12-04T08:10:30Z

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

NetaNir

See my comments about the Python runtime additions. The Canary module assume the runtime is always Nodejs, and enforce the below:

The Canary code does include node_moduels folder. See synthetics docs: https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Synthetics_Canaries_WritingCanary_Nodejs.html
The handler file is named index.handler

Before we introduce Python as runtime we need to address it. Im happy to accept a PR which adds the new node runtime in the meantime

NetaNir · 2020-12-04T21:52:14Z

packages/@aws-cdk/aws-synthetics/test/canary.test.ts

      code: synthetics.Code.fromInline('/* Synthetics handler code */'),
    }),
-    runtime: synthetics.Runtime.SYNTHETICS_NODEJS_2_0,
+    runtime: synthetics.Runtime.SYNTHETICS_NODEJS_2_2,


I would actually prefer we leave some of the test using other values, as they are valid configuration.
I don't see a reason to change all tests to use the latest version.

It was mainly because the linter was asking for unit test update.

Why was this comment resolve? The linter rule can be exempt. Lets change it back

Sorry about that I didn't know it can be exempt. reverting to 2_0

NetaNir · 2020-12-04T21:59:27Z

packages/@aws-cdk/aws-synthetics/lib/canary.ts

+   *
+   * @see https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Synthetics_Library_python_selenium.html#CloudWatch_Synthetics_runtimeversion-syn-python-selenium-1.0
+   */
+  public static readonly SYNTHETICS_PYTHON_1_0 = new Runtime('syn-python-selenium-1.0');


Does this means that synthetics now support non NodeJs lambda functions? If so we need to change how we handle the assets code, which assumes the code is stored in a node_module folder, per synthetics official docs .

This will require a larger code change, Im not sure what is the right API here, we might need separate class for Python runtimes Canaries and Nodejs Canaries.

I'll do another PR for Python one if it's ok. I removed python for now.

Pull request has been modified.

NetaNir · 2020-12-22T05:56:25Z

packages/@aws-cdk/aws-synthetics/README.md

    handler: 'index.handler',
  }),
-  runtime: synthetics.Runtime.SYNTHETICS_NODEJS_2_0,
+  runtime: synthetics.Runtime.SYNTHETICS_NODEJS_2_1,


why did you use SYNTHETICS_NODEJS_2_1 and not SYNTHETICS_NODEJS_2_2 in all code samples? If the answer is "It does not matter" then it shouldn't be changed

right. my bad , pushed 2_2 in all examples to guide customer towards latest version.

Pull request has been modified.

flochaz · 2021-01-04T08:49:03Z

@NetaNir anything else I missed ?

NetaNir · 2021-01-04T18:11:46Z

packages/@aws-cdk/aws-synthetics/README.md


-The Canary code will be executed in a lambda function created by Synthetics on your behalf. The Lambda function includes a custom [runtime](https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Synthetics_Canaries_Library.html) provided by Synthetics. The provided runtime includes a variety of handy tools such as [Puppeteer](https://www.npmjs.com/package/puppeteer-core) and Chromium. The default runtime is `syn-nodejs-2.0`.
+The Canary code will be executed in a lambda function created by Synthetics on your behalf. The Lambda function includes a custom [runtime](https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Synthetics_Canaries_Library.html) provided by Synthetics. The provided runtime includes a variety of handy tools such as [Puppeteer](https://www.npmjs.com/package/puppeteer-core) (for nodejs based one) and Chromium.



This should have been removed when the runtime property was made a required property. Can you remove it (instead of fixing it)

I removed it, I just mentioned that pupetter is for nodejs runtime only since python one use selenium. But If you prefer I'll keep that for python PR.

Pull request has been modified.

aws-cdk-automation · 2021-01-07T22:26:43Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 1e883ae
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2021-01-07T23:55:32Z

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

flochaz force-pushed the flochaz/updatedCanaryRuntime branch 2 times, most recently from a086868 to 17a7e1d Compare December 4, 2020 08:31

flochaz changed the title ~~feat: Update Cloudwatch Synthetics canaries runtime~~ feat(synthetics): Update Cloudwatch Synthetics canaries runtime Dec 4, 2020

github-actions bot assigned NetaNir Dec 4, 2020

github-actions bot added the @aws-cdk/aws-synthetics Related to Amazon CloudWatch Synthetics label Dec 4, 2020

update canaries runtime

7c09f34

flochaz force-pushed the flochaz/updatedCanaryRuntime branch from 17a7e1d to 7c09f34 Compare December 4, 2020 08:37

Fix semantic test

ddb3ba8

andiempett approved these changes Dec 4, 2020

View reviewed changes

Merge branch 'master' into flochaz/updatedCanaryRuntime

854cc71

danataws approved these changes Dec 4, 2020

View reviewed changes

NetaNir previously requested changes Dec 4, 2020

View reviewed changes

NetaNir mentioned this pull request Dec 5, 2020

(synthetics): Add new runtimes #11870

Closed

2 tasks

removed python runtime, will be part of another PR

26070df

flochaz changed the title ~~feat(synthetics): Update Cloudwatch Synthetics canaries runtime~~ feat(synthetics): Update Cloudwatch Synthetics canaries NodeJS runtimes Dec 7, 2020

Merge branch 'master' into flochaz/updatedCanaryRuntime

d4e53a3

NetaNir previously requested changes Dec 22, 2020

View reviewed changes

don't modify unit test

6749576

flochaz added 2 commits December 29, 2020 09:44

update examples with latest runtime

6d2b666

Merge branch 'master' into flochaz/updatedCanaryRuntime

bd18327

NetaNir suggested changes Jan 4, 2021

View reviewed changes

NetaNir previously approved these changes Jan 4, 2021

View reviewed changes

NetaNir added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes labels Jan 4, 2021

Merge branch 'master' into flochaz/updatedCanaryRuntime

b143f42

Merge branch 'master' into flochaz/updatedCanaryRuntime

1e883ae

NetaNir approved these changes Jan 7, 2021

View reviewed changes

mergify bot merged commit 4f6e377 into aws:master Jan 7, 2021

flochaz deleted the flochaz/updatedCanaryRuntime branch January 8, 2021 08:03

kaizencc mentioned this pull request Aug 12, 2021

(synthetics): add Runtime property for syn-python-selenium-1.0 to create synthetics canary #15138

Closed

2 tasks


		The Canary code will be executed in a lambda function created by Synthetics on your behalf. The Lambda function includes a custom [runtime](https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Synthetics_Canaries_Library.html) provided by Synthetics. The provided runtime includes a variety of handy tools such as [Puppeteer](https://www.npmjs.com/package/puppeteer-core) and Chromium. The default runtime is `syn-nodejs-2.0`.
		The Canary code will be executed in a lambda function created by Synthetics on your behalf. The Lambda function includes a custom [runtime](https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Synthetics_Canaries_Library.html) provided by Synthetics. The provided runtime includes a variety of handy tools such as [Puppeteer](https://www.npmjs.com/package/puppeteer-core) (for nodejs based one) and Chromium.

Conversation

flochaz commented Dec 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gitpod-io bot commented Dec 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mergify bot commented Dec 4, 2020

Uh oh!

NetaNir left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

flochaz Dec 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

flochaz commented Jan 4, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

flochaz Jan 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aws-cdk-automation commented Jan 7, 2021

AWS CodeBuild CI Report

Uh oh!

mergify bot commented Jan 7, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

flochaz commented Dec 4, 2020 •

edited

Loading

gitpod-io bot commented Dec 4, 2020 •

edited

Loading

NetaNir left a comment •

edited

Loading

flochaz Dec 7, 2020 •

edited

Loading

flochaz Jan 4, 2021 •

edited

Loading